Get parent model from its child relation #328

xyz1123581321 · 2021-10-06T13:52:15Z

If the parent relation is defined in its child relation, then assign its parent model to its child

RomainMazB · 2021-10-06T14:06:58Z

Is it related to any issue?
Which problem or situation are you trying to solve or feature are you trying to implement?

modules/backend/behaviors/RelationController.php

xyz1123581321 · 2021-10-06T19:01:46Z

We talked about this small improvement on discord with Luke.

RomainMazB · 2021-10-06T19:35:40Z

Ok, just for prosperity I post here the issue from the OC forum you are trying to solve. Just for others who don't know like me what's going on here :)

I have 2 models: Item and ItemPrice
Item hasMany ItemPrices
ItemPrice belongsTo Item

When I create new ItemPrice from Item update form (using relation controller), I need to access Item model (i.e parent model) when generation dropdown options in related model form.
Something like $this->item->...
But relation controller doesn't set relation to parent model before related model is added.

xyz1123581321 · 2021-10-11T20:48:19Z

Did you review it?

modules/backend/behaviors/RelationController.php

LukeTowers · 2021-10-11T20:53:07Z

modules/backend/behaviors/RelationController.php

@@ -657,7 +682,6 @@ protected function makeSearchWidget()
    protected function makeViewWidget()
    {
        $widget = null;
-


Needs to have whitespace added back in

I didn't change anything at 660...
Only 362 to 382.

/* * Parent relationship */ $parentClass = get_class($this->model); $allRelationDefinitions = $this->relationModel->getRelationDefinitions(); $parentClassName = ""; foreach ($allRelationDefinitions as $relations) { foreach ($relations as $key => $value) { if (strtolower($value[0]) == strtolower($parentClass)) { $parentClassName = $key; } } } if ($parentClassName != "") { $this->relationModel->{$parentClassName} = $this->model; }

modules/backend/behaviors/RelationController.php

LukeTowers · 2021-10-11T20:57:13Z

modules/backend/behaviors/RelationController.php

+                    break;
+                }
+            }
+        }


This seems a bit fragile to me, I hadn't realized the complexity of setting the inverse relationship. @bennothommo do you have any ideas for this?

Right now I'm concerned about how well it supports all of the relationship modes supported by the RelationController and also if the related model has multiple relationship definitions tying back to the original parent model, how would we support that / should we try to support that? I'm thinking our best bet for that issue is to explicitly detect any more than one possible inverse relationship and don't do anything if that's encountered. It's already a bit presumptuous to be setting the inverse relationship directly when it might have scopes or conditions limiting the current parent model from being set in the first place.

Or perhaps I'm just overthinking this all, @bennothommo any thoughts on the above?

@bennothommo ping

Sorry for the extreme delay in responding to this one!

It is somewhat flimsy, but at the same time - conventionally speaking - we should be alright. I can't think of a better way right now, and even if I could, there's no telling whether it would work or not given our relation definition is completely different to Laravel's.

github-actions · 2021-12-11T00:14:25Z

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions · 2022-02-11T00:17:28Z

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions · 2022-04-15T00:22:42Z

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

github-actions · 2022-10-15T00:42:17Z

This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months.
If you intend to continue working on this pull request, please respond within 3 days.
If this pull request is critical for your business, please reach out to us at [email protected].

github-actions · 2023-08-22T00:23:26Z

This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months.
If you intend to continue working on this pull request, please respond within 3 days.
If this pull request is critical for your business, please reach out to us at [email protected].

bennothommo · 2023-08-22T00:37:17Z

@LukeTowers anything else required here?

mjauvin · 2023-08-22T02:09:39Z

The way I do this personally is this in the related model constructor:

public function __construct(array $attributes = [])
{
    parent::__construct($attributes);
    $this->bindEvent('model.form.filterFields', function ($formWidget, $fields, $context) {                                              
        if ($context === 'create') {
            if ($model = $formWidget->model) {
                $model->parent = $formWidget->getController()->relationObject->getParent();
            }
        }
    }
}

LukeTowers · 2023-08-22T07:26:36Z

I'm concerned about knock-on effects from making this sort of change, is it possible to simplify the problem down to a small demo of the issue that can have test cases documenting the expectations and then verify the solution from there or is it too complicated with how it integrates with the relationcontroller functionality?

Either way I'll need to spend some time on this to refresh my memory on what the original problem was as well as how this solved it and my original concerns. Is there still interest in getting this merged or is @mjauvin's proposed workaround decent enough for anyone else encountering this sort of bump in the road?

github-actions · 2024-02-21T00:25:31Z

This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months.
If you intend to continue working on this pull request, please respond within 3 days.
If this pull request is critical for your business, please reach out to us at [email protected].

mjauvin · 2024-02-21T01:10:43Z

I just use the following:

$formwidget->getController()->relationObject->getParent();

bennothommo · 2024-02-21T01:18:50Z

Let's close this for now, given there are available workarounds. If someone wishes to take charge of this and get this over the line, feel free to drop a line here and we'll re-open.

xyz1123581321 added 2 commits October 6, 2021 12:12

Access relationship parent from its child relation

a1284ec

If the parent relation is defined in its child relation, then assign its parent model to its child

Access relationship parent from its child relation

f5f1cd0

If the parent relation is defined in its child relation, then assign its parent model to its child

xyz1123581321 changed the title ~~Pr 325~~ Get parent model from its child relation Oct 6, 2021

RomainMazB reviewed Oct 6, 2021

View reviewed changes

modules/backend/behaviors/RelationController.php Outdated Show resolved Hide resolved

RomainMazB reviewed Oct 6, 2021

View reviewed changes

modules/backend/behaviors/RelationController.php Outdated Show resolved Hide resolved

Codestyles fixes

9d82a04

Comment fixes

367331b

Codestyle fixes

19e9807

LukeTowers requested changes Oct 11, 2021

View reviewed changes

Apply suggestions from code review

228f8ba

LukeTowers reviewed Oct 11, 2021

View reviewed changes

github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Dec 11, 2021

bennothommo removed the stale Issues/PRs that have had no activity and may be archived label Dec 12, 2021

github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Feb 11, 2022

bennothommo added needs review Issues/PRs that require a review from a maintainer Type: Conceptual Enhancement and removed stale Issues/PRs that have had no activity and may be archived labels Feb 13, 2022

github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Apr 15, 2022

bennothommo removed the stale Issues/PRs that have had no activity and may be archived label Apr 15, 2022

github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Oct 15, 2022

bennothommo removed the stale Issues/PRs that have had no activity and may be archived label Oct 15, 2022

github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Aug 22, 2023

mjauvin closed this Aug 22, 2023

mjauvin reopened this Aug 22, 2023

LukeTowers removed the stale Issues/PRs that have had no activity and may be archived label Aug 22, 2023

github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Feb 21, 2024

bennothommo closed this Feb 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get parent model from its child relation #328

Get parent model from its child relation #328

xyz1123581321 commented Oct 6, 2021 •

edited by gitpod-io bot

Loading

RomainMazB commented Oct 6, 2021

xyz1123581321 commented Oct 6, 2021

RomainMazB commented Oct 6, 2021

xyz1123581321 commented Oct 11, 2021

LukeTowers Oct 11, 2021

xyz1123581321 Oct 11, 2021

LukeTowers Oct 11, 2021

LukeTowers Oct 24, 2022

bennothommo Feb 20, 2023

github-actions bot commented Dec 11, 2021

github-actions bot commented Feb 11, 2022

github-actions bot commented Apr 15, 2022

github-actions bot commented Oct 15, 2022

github-actions bot commented Aug 22, 2023

bennothommo commented Aug 22, 2023

mjauvin commented Aug 22, 2023 •

edited

Loading

LukeTowers commented Aug 22, 2023

github-actions bot commented Feb 21, 2024

mjauvin commented Feb 21, 2024

bennothommo commented Feb 21, 2024

Get parent model from its child relation #328

Get parent model from its child relation #328

Conversation

xyz1123581321 commented Oct 6, 2021 • edited by gitpod-io bot Loading

RomainMazB commented Oct 6, 2021

xyz1123581321 commented Oct 6, 2021

RomainMazB commented Oct 6, 2021

xyz1123581321 commented Oct 11, 2021

LukeTowers Oct 11, 2021

Choose a reason for hiding this comment

xyz1123581321 Oct 11, 2021

Choose a reason for hiding this comment

LukeTowers Oct 11, 2021

Choose a reason for hiding this comment

LukeTowers Oct 24, 2022

Choose a reason for hiding this comment

bennothommo Feb 20, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 11, 2021

github-actions bot commented Feb 11, 2022

github-actions bot commented Apr 15, 2022

github-actions bot commented Oct 15, 2022

github-actions bot commented Aug 22, 2023

bennothommo commented Aug 22, 2023

mjauvin commented Aug 22, 2023 • edited Loading

LukeTowers commented Aug 22, 2023

github-actions bot commented Feb 21, 2024

mjauvin commented Feb 21, 2024

bennothommo commented Feb 21, 2024

xyz1123581321 commented Oct 6, 2021 •

edited by gitpod-io bot

Loading

mjauvin commented Aug 22, 2023 •

edited

Loading